Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR addressing Issue #280 #281

Merged
merged 2 commits into from
Dec 13, 2022
Merged

PR addressing Issue #280 #281

merged 2 commits into from
Dec 13, 2022

Conversation

Max-Bladen
Copy link
Collaborator 

✔  creating vignettes (3m 3.7s)
   Warning in person1(given = given[[i]], family = family[[i]], middle = middle[[i]],  :
     It is recommended to use 'given' instead of 'middle'.

Resolved by moving the "J" (as middle) to the first name (as given) for Al J Abadi in DESCRIPTION`

─  checking for empty or unneeded directories
   Removed empty directory 'mixOmics/.vscode'
   Removed empty directory 'mixOmics/R/New folder'
   Removed empty directory 'mixOmics/build'
   Removed empty directory 'mixOmics/tests/testthat/_snaps'

Removed all empty folders except for mixOmics/build - this folder only exists during build process

N  checking installed package size ... 
     installed size is  9.5Mb
     sub-directories of 1Mb or more:
       R      1.4Mb
       data   3.3Mb
       doc    3.3Mb

Can't really do anything about this, leaving it for now

N  checking R code for possible problems (32.6s)
   predict.block.pls: no visible global function definition for 'setNames'
   ...

Added @importFrom stats setNames to predict() documentation

@Max-Bladen
Fix for Issue 280
1357c37 
build: added explicit global definition for `setNames()`. Resolves NOTE in R-CMD-Check
@Max-Bladen
Fix for Issue #280
496c6d6 
build: removed `middle` parameter from Al Abadi's reference in DESCRIPTION
@Max-Bladen Max-Bladen added build-improvement wip work-in-progress labels Dec 12, 2022
@Max-Bladen Max-Bladen linked an issue Dec 12, 2022 that may be closed by this pull request
R-CMD-CHECK warnings & notes #280
Closed
@Max-Bladen Max-Bladen merged commit 1820bef into master Dec 13, 2022
@Max-Bladen Max-Bladen deleted the issue-280 branch December 13, 2022 00:00
@Max-Bladen Max-Bladen removed the wip work-in-progress label Dec 13, 2022
This was referenced Dec 13, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build-improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

R-CMD-CHECK warnings & notes
1 participant
@Max-Bladen